Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim whitespaces from configured channel and port filters #4045

Closed
5 tasks
ljoss17 opened this issue Jun 18, 2024 · 0 comments · Fixed by #4044
Closed
5 tasks

Trim whitespaces from configured channel and port filters #4045

ljoss17 opened this issue Jun 18, 2024 · 0 comments · Fixed by #4044
Assignees
Labels
I: configuration Internal: related to Hermes configuration
Milestone

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jun 18, 2024

Current process

When verifying the channel and port filter policy Hermes will verify if the list has wildcard values or not.
If there are only exact matches channel scanning will be skipped.

The current solution will not consider a channel or port as an exact match if there is a whitespace, e.g.:

            policy = "allow"
            list = [
                [ "transfer", "channel-1", ],
                [ "transfer", "channel-2 ", ], # Trailing whitespace
            ]

This will trigger channel scanning.

Proposal

Since whitespaces are not allowed in channel or port names, it is acceptable to trim them from the configured values.
This will avoid channel scanning from unimpactful typos.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 added the I: configuration Internal: related to Hermes configuration label Jun 18, 2024
@ljoss17 ljoss17 self-assigned this Jun 18, 2024
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jun 18, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Jun 18, 2024
@ljoss17 ljoss17 added this to the v1.10 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: configuration Internal: related to Hermes configuration
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant