Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve channel and port filter policy parsing #4044

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jun 18, 2024

Closes: #4045

Description

This PR adds whitespace trimming before parsing values in the list of packet_filter configuration.

This will avoid triggering channel scanning if there is an unintended whitespace, e.g.:

    policy = "allow"
    list = [
        [ "transfer", "channel-1 ", ],
    ]

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac June 18, 2024 09:57
@ljoss17 ljoss17 marked this pull request as ready for review June 18, 2024 10:00
@ljoss17 ljoss17 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into master with commit 5889131 Jun 18, 2024
30 checks passed
@ljoss17 ljoss17 deleted the luca_joss/improve-channel-filter-policy-parsing branch June 18, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim whitespaces from configured channel and port filters
2 participants