Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas fee has denom and amount hard-coded #754

Closed
5 tasks
andynog opened this issue Mar 20, 2021 · 2 comments · Fixed by #769
Closed
5 tasks

Gas fee has denom and amount hard-coded #754

andynog opened this issue Mar 20, 2021 · 2 comments · Fixed by #769
Labels
A: bug Admin: something isn't working I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic
Milestone
03.2021

Comments

@andynog
Copy link
Contributor

andynog commented Mar 20, 2021

Crate

ibc-relayer

Summary of Bug

Currently in the sent_tx method of the cosmos.rs file, the gas fee logic has the denom (stake) and amount (`

https://github.com/informalsystems/ibc-rs/blob/9e6848494332ffa8283b92c113beea5833e100bc/relayer/src/chain/cosmos.rs#L182

Version

v0.1.1

Steps to Reproduce

There are no steps to reproduce. Currently with this logic there's no way to submit transactions to a chain if the gas fee denom is not stake. And the gas fee amount should also be dynamic (allowed to be specified trough a command line parameter)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@andynog andynog added A: bug Admin: something isn't working I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic labels Mar 20, 2021
@andynog andynog added this to the 03.2021 milestone Mar 20, 2021
@andynog andynog mentioned this issue Mar 22, 2021
Merged
5 tasks
@ancazamfir
Copy link
Collaborator

Trying a transaction on akashnet-2 I get this:
{"status":"success","result":{"ChainError":"check_tx reports error: log=Log(\"insufficient fees; got: 10000stake required: 75000uakt: insufficient fee\")"}}

@andynog
Copy link
Contributor Author

andynog commented Mar 24, 2021

This issue needs to be fixed to allow custom fee and denom

andynog added a commit that referenced this issue Mar 25, 2021
@andynog
Make the fee amount and denom part of the config (#754)
ba72f00
andynog added a commit that referenced this issue Mar 25, 2021
@andynog
Adding missing fee parameters to configs (#754)
f13eb16
@andynog andynog mentioned this issue Mar 25, 2021
Merged
5 tasks
romac added a commit that referenced this issue Mar 27, 2021
@andynog @romac
Make fee denom and amount configurable (#769)
d4e29d4 
* Make the fee amount and denom part of the config (#754)

* Adding missing fee parameters to configs (#754)

* Update changelog (#769)

* Update relayer/src/chain/cosmos.rs

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Update relayer/src/chain/cosmos.rs

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Update relayer/src/chain/cosmos.rs

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Fix for e2e failure

* Fixing config for ci (#769)

Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
@andynog @romac
Make fee denom and amount configurable (informalsystems#769)
dd00e5a 
* Make the fee amount and denom part of the config (informalsystems#754)

* Adding missing fee parameters to configs (informalsystems#754)

* Update changelog (informalsystems#769)

* Update relayer/src/chain/cosmos.rs

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Update relayer/src/chain/cosmos.rs

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Update relayer/src/chain/cosmos.rs

Co-authored-by: Romain Ruetschi <romain@informal.systems>

* Fix for e2e failure

* Fixing config for ci (informalsystems#769)

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic
Projects
None yet
Milestone
03.2021
Development

Successfully merging a pull request may close this issue.

Make fee denom and amount configurable informalsystems/hermes
2 participants
@ancazamfir @andynog