Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tonic to 0.4.3 #1080

Closed
wants to merge 1 commit into from
Closed

update tonic to 0.4.3 #1080

wants to merge 1 commit into from

Conversation

allthatjazzleo
Copy link
Contributor

Closes: #1079

Description

update tonic to 0.4.3 to support Configure TLS automatically when possible

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac
Copy link
Member

romac commented Jun 14, 2021

I am not sure why this change is needed? This feature was already part of tonic 0.4.0, (released on Jan 15, 2021) and because we specify the tonic dependency as "0.4", we area already pulling in tonic 0.4.3.

It does not hurt to merge it anyway, but can explain why we need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update tonic to 0.4.3
2 participants
@allthatjazzleo @romac