Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health checkup mechanism #1145

Merged
merged 11 commits into from
Jul 6, 2021
Merged

Add health checkup mechanism #1145

merged 11 commits into from
Jul 6, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Jul 1, 2021 •
edited
Loading

Closes: #697
Closes: #1057

Needs guide update for the SDK compatibility range.

Testing instructions:

  • to reproduce 697:
    • apply this patch then run dev-env to produce two gaia instances, both of which will have transaction indexing disabled
    • then run hermes query clients ibc-0
    • you should see a WARN log

Jul 02 15:36:03.226 WARN Hermes health check failed for endpoint /tx_search on the Json RPC interface of chain ibc-0:http://127.0.0.1:26657/; reported error: Internal error: transaction indexing is disabled (code: -32603)
Jul 02 15:36:03.226 WARN some Hermes features may not work in this mode!

  • to test the warning against a non-healthy full node:
    • just kill your gaiad instances using killall gaiad
    • run hermes query clients ibc-0

Jul 02 16:26:51.212 WARN Hermes health check failed for endpoint /health on the Json RPC interface of chain ibc-0:http://127.0.0.1:26657/; caused by: error trying to connect: tcp connect error: Connection refused (os error 61) (code: 0)
Jul 02 16:26:51.212 WARN some Hermes features may not work in this mode!
Error: query error: GRPC error: transport error: error trying to connect: tcp connect error: Connection refused (os error 61)

  • to test other warnings:
    • install a gaia version that is unsupported
    • cd $GAIA_DIR ; git co colin/upgrade-testing
    • make install to update your gaia to this new version, which builds on unsupported SDK 0.43+
    • run dev-env to start two gaia instances
    • then run hermes query clients ibc-0
    • you should see a WARN log

Jul 03 10:45:17.899 WARN Hermes health check failed for endpoint /tx_search on the Json RPC interface of chain ibc-0:http://127.0.0.1:26657/; caused by: Internal error:
parse error near Unknown (line 1 symbol 1 - line 1 symbol 1):
""
(code: -32603)
Jul 03 10:45:17.899 WARN some Hermes features may not work in this mode!

TODO

  • test with gaia v5 to make sure the SDK is supported

Description

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere marked this pull request as ready for review July 2, 2021 14:17
This was linked to issues Jul 2, 2021
Setup IBC #697
Closed
Add support for Hermes to identify whether it is compatible with a chain (based on SDK version) #1057
Closed
@adizere adizere added the E: gravity External: related to Gravity DEX label Jul 5, 2021
@adizere adizere changed the base branch from adi/tx_partition to master July 6, 2021 11:28
@adizere adizere changed the base branch from master to adi/tx_partition July 6, 2021 11:29
@adizere adizere changed the base branch from adi/tx_partition to master July 6, 2021 11:48
@adizere adizere merged commit 3da7dc1 into master Jul 6, 2021
@adizere adizere deleted the adi/697_txindexing branch July 6, 2021 12:52
@adizere adizere mentioned this pull request Sep 27, 2021
Closed
5 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@adizere @soareschen
Add health checkup mechanism (informalsystems#1145)
e7ea73d 
* Added health checkup mechanism for CosmosSDK

* Added SDK compat diagnostic check

* Added fix for leading v in semver

* Lowered log to warn. Added early exit

* Reverted the one-chain patch to enable indexing

* changelog

* Improve health_checkup async code flow

* Tentative fix for tx_search parsing error bug which Soares found.

* Update compatibility version bound to v0.42.6 to work with gaia v5.0.0

* Aesthetic & comments improvements.

* Removed stale tracing import (became stale after rebasing onto master)

Co-authored-by: Soares Chen <soares.chen@maybevoid.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees

@soareschen soareschen

Labels
E: gravity External: related to Gravity DEX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Hermes to identify whether it is compatible with a chain (based on SDK version) Setup IBC
2 participants
@adizere @soareschen