Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set capability index #1258

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Set capability index #1258

merged 1 commit into from
Aug 3, 2021

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Aug 3, 2021

Closes: cosmos/ibc-rs#74

Description

  • Set and get the index for ibc::ics05_port::capabilities::Capability

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@yito88 yito88 changed the title fix: set capability index Set capability index Aug 3, 2021
@adizere
Copy link
Member

adizere commented Aug 3, 2021

FYI @hu55a1n1: this is a minor change but just to keep you in the loop with how the handlers progress.

@adizere adizere merged commit ebf9d31 into informalsystems:master Aug 3, 2021
@yito88 yito88 deleted the yuji/set_capability_index branch August 3, 2021 16:07
yito88 added a commit to heliaxdev/ibc-rs that referenced this pull request Aug 16, 2021
@yito88
fix: set capability index (informalsystems#1258)
a5ca232
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@yito88
fix: set capability index (informalsystems#1258)
80e5b0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yito88 @adizere