Fix header decoding errors #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
requested changes
Sep 13, 2021
| @@ -71,8 +71,14 @@ pub fn extract_header_from_tx(event: &tendermint::abci::Event) -> Option<AnyHead | |||
| let value = tag.value.as_ref(); | |||
| if let HEADER = key { | |||
| let header_bytes = hex::decode(value).unwrap(); | |||
| let header: AnyHeader = Protobuf::decode(header_bytes.as_ref()).unwrap(); | |||
| return Some(header); | |||
| let result = match Protobuf::decode(header_bytes.as_ref()) { | |||
There was a problem hiding this comment.
How about we just return Result directly and let the calling code in the relayer trace the underlying error?
There was a problem hiding this comment.
Maybe try_from_tx should see its signature changed from
pub fn try_from_tx(event: &tendermint::abci::Event) -> Option<IbcEvent> to
pub fn try_from_tx(event: &tendermint::abci::Event) -> (Option<IbcEvent>, Vec<Error>)so that we can still build the IbcEvent even if the header decoding failed, but also return any errors encountered (eg. the header decoding error itself).
|
While we're at it, we should perhaps also address the |
|
Let's address my comments in a follow-up PR. |
romac
approved these changes
Sep 14, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Return None when header cannot be decoded * More details in misbehaviour error * Set the event height and include it in the error * Add .changelog entry Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1342
Description
For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.