Support for toggling tx confirmation mechanism #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancazamfir
reviewed
Sep 22, 2021
There was a problem hiding this comment.
after a quick look, I think that if we hit the periodic clear packet with pending transactions we will submit those again. Maybe @mircea-c could do some eval, maybe in the end it is a small price to pay.
soareschen
reviewed
Sep 22, 2021
soareschen
approved these changes
Sep 24, 2021
5 tasks
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Support for toggling tx confirmation mechanism * Small thrifty optimizations * Optimize schedule refreshing * changelog * Comment * More cautious comments * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1380
Description
For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.