Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the consensus_params rpc with explicit (latest) height #1382

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Use the consensus_params rpc with explicit (latest) height #1382

merged 4 commits into from
Sep 24, 2021

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Sep 22, 2021 •
edited by romac
Loading

Closes: #1376

Description

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac marked this pull request as ready for review September 23, 2021 14:44
adizere
adizere approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anca!

@adizere adizere merged commit 859d659 into master Sep 24, 2021
@adizere adizere deleted the anca/rpc_consensus_params branch September 24, 2021 07:15
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@ancazamfir @romac
Use the consensus_params rpc with explicit (latest) height (informals…
65e17fb 
…ystems#1382)

* Use the consensus_params rpc with explicit (latest) height

* remove qualification

* Add .changelog entry

* Rename variable

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Health-check fails because /consensus_params endpoint is not reliable
3 participants
@ancazamfir @adizere @romac