Set default trusting period to be 2/3 of unbonding period for Cosmos chains #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu55a1n1
requested review from
adizere,
ancazamfir and
romac
as code owners
romac
reviewed
Sep 28, 2021
romac
requested changes
Sep 28, 2021
| @@ -322,8 +318,7 @@ pub struct ChainConfig { | |||
| pub max_tx_size: MaxTxSize, | |||
| #[serde(default = "default::clock_drift", with = "humantime_serde")] | |||
| pub clock_drift: Duration, | |||
| #[serde(default = "default::trusting_period", with = "humantime_serde")] | |||
There was a problem hiding this comment.
Removing the serde(with) attribute means we cannot express the trusting period as a human readable string, eg. 14days. Let's find a way to re-enable it :)
There was a problem hiding this comment.
Done! Thanks for reviewing, @romac!
5 tasks
5 tasks
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1133
Description
Set config trusting period to be 2/3 of unbonding period if not specified for Cosmos chains.
This is done where the
ChainEndpointimpl for chains exists because we aren't sure if a chain is a Cosmos SDK chain while parsing the config.For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.