Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compatibility.rs to check for IBC-go dependency #1431

Merged
merged 10 commits into from
Oct 19, 2021
Merged

Update compatibility.rs to check for IBC-go dependency #1431

merged 10 commits into from
Oct 19, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Oct 6, 2021 •
edited
Loading

Closes: #1464

Description

  • update the guide to indicate compat with ibc-go (in addition to SDK v0.44)
    • we'll do this in the release PR
  • The SDK is moving quite fast through point releases (i.e., patches), so we'll make the compatibility check against the minor version (0.44) instead of specifying down to the patch (0.44.1) as we currently do.
  • lower the error log level of the health check output to warning (can generate confusion otherwise, reported by multiple, including TM-go staff)

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac self-assigned this Oct 18, 2021
@romac romac mentioned this pull request Oct 18, 2021
Closed
16 tasks
@romac romac marked this pull request as ready for review October 18, 2021 08:12
@adizere adizere merged commit d759f79 into master Oct 19, 2021
@adizere adizere deleted the adi/1408_vega branch October 19, 2021 13:15
@romac romac mentioned this pull request Oct 19, 2021
Closed
5 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@adizere @romac
Update compatibility.rs to check for IBC-go dependency (informalsyste…
c088a22 
…ms#1431)

* Update compat to check IBC-go dependency

* Updated ibc-go vers to match the ibc-go repo releases

* Added lost changelog entry for issue informalsystems#1433

* Lower log level of health check to warning

* Relax compatibility check from patch version to minor version

* Relax compat versions to `>=0.41, <0.45` for SDK and `>=1.1, <1.2` for IBC-Go

* Add .changelog entry

* Comment fix

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM left review comments

@romac romac romac approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees

@romac romac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update compatibility.rs to check for IBC-go dependency
3 participants
@adizere @romac @RiccardoM