Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured logs for relayer logic #1491

Merged
merged 37 commits into from
Jan 17, 2022
Merged

Structured logs for relayer logic #1491

merged 37 commits into from
Jan 17, 2022

Commits on Oct 25, 2021

  1. Configuration menu
    Copy the full SHA
    a29c9c7 View commit details
    Browse the repository at this point in the history
  2. Pass 2

    adizere committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    4df293f View commit details
    Browse the repository at this point in the history
  3. Pass 3

    adizere committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    5ae8e42 View commit details
    Browse the repository at this point in the history
  4. Resolving todos, refactoring

    adizere committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    50ff524 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Better config.toml comment

    adizere committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    794a7bf View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Configuration menu
    Copy the full SHA
    cc5e158 View commit details
    Browse the repository at this point in the history
  2. Post-merge fixes

    adizere committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    d75c832 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Configuration menu
    Copy the full SHA
    9d17f44 View commit details
    Browse the repository at this point in the history
  2. Post-merge fix

    mzabaluev committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    a2c3311 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Sketch: printing tx hashes from SendPacket events.

    This was inspired from commit b63335b
    (see rpc.rs therein).
    adizere committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    5906035 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Configuration menu
    Copy the full SHA
    74913b7 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Improve code to print out the tx hash

    Just examine the hash map, do not allocate any copies.
    mzabaluev committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    dcf662a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f9ca4db View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Apply suggestions from code review

    Co-authored-by: Mikhail Zabaluev <mikhail@informal.systems>
    adizere and mzabaluev committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    5de3f2b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1d15085 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    60e66e6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4d94d54 View commit details
    Browse the repository at this point in the history
  5. Erase Display impl for TrackedMsgs

    Add tracking_id method to use in tracing instead.
    
    Also, use less cryptic span names in send_messages_*.
    mzabaluev committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    d189d2c View commit details
    Browse the repository at this point in the history
  6. Allow passing IDs without copy in TrackedMsgs

    Make the tracking ID construction parameter generic to accept any
    Into<String> parameter.
    mzabaluev committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    3166f76 View commit details
    Browse the repository at this point in the history
  7. Different tracking ids for creation flows

    Identify TrackedMsgs batches for creating channels and connections
    with the specific message that is used.
    mzabaluev committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    c93249b View commit details
    Browse the repository at this point in the history
  8. Redo displaying for OperationalData

    Add OperationalInfo that can hold the displayable data on the batch,
    either borrowed or owned with transforming from first to the other.
    Implement Display on the OperationalInfo instead of OperationalData
    for clarity.
    mzabaluev committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    1bba81b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6df6b63 View commit details
    Browse the repository at this point in the history
  10. Improve logging of operational data

    Use the `odata` key in tracing.
    mzabaluev committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    85c60fa View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Configuration menu
    Copy the full SHA
    b8e9c7c View commit details
    Browse the repository at this point in the history
  2. Remove verbose wording on TrackedMsgs IDs

    The operation name is usually enough.
    mzabaluev committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    d84bccd View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Configuration menu
    Copy the full SHA
    c5f7d87 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0507161 View commit details
    Browse the repository at this point in the history
  3. Use a tracing span for task log messages

    The task lifetime is better tracked with a tracing span,
    which also reduces code repetition in tracking macros by putting in
    the task name once.
    mzabaluev committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    914373c View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Rework tracing spans for background tasks

    spawn_background_task receives a Span constructed by the caller.
    This allows embedding contextual information for the task, which is
    used to reduce repetition in logging macros for the workers.
    mzabaluev committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    d1ae093 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    108d081 View commit details
    Browse the repository at this point in the history
  3. Erase Display impl on RelayPath, use spans instead

    With spans injecting all of the information that was formatted
    using the RelayPath Display impl, this is redundant.
    mzabaluev committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    e6b41f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Shorten or remove span IDs for supervisor tasks

    For the batch worker tasks, we should have a span with the task name
    and other details, so the top-level span is not needed.
    For other supervisor tasks, the span name is shortened.
    mzabaluev committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    73d135e View commit details
    Browse the repository at this point in the history
  2. Erase [rest] prefixes from log messages

    We have the span now, these are redundant and bad style.
    mzabaluev committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    6cb9023 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Configuration menu
    Copy the full SHA
    c69aa81 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ae8880 View commit details
    Browse the repository at this point in the history
  3. Changelog entry for #1491

    mzabaluev committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    bfec7d6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    45a9761 View commit details
    Browse the repository at this point in the history