Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for packet timeout computation #1520

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Fix for packet timeout computation #1520

merged 3 commits into from
Oct 29, 2021

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Oct 28, 2021 •
edited by adizere
Loading

…packets

Closes: #1504

Description

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere changed the title Use latest block time instead of wall time when checking for timeout … Fix for packet timeout computation Oct 29, 2021
@adizere adizere self-assigned this Oct 29, 2021
adizere
adizere approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@adizere adizere merged commit 341fd0d into master Oct 29, 2021
@adizere adizere deleted the anca/1504_timeout branch October 29, 2021 09:54
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@ancazamfir @adizere
Fix for packet timeout computation (informalsystems#1520)
679ef48 
* Use latest block time instead of wall time when checking for timeout packets

* Add changelog

* Nit: renamed arg to timed_out, added comment.

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@romac romac Awaiting requested review from romac

Assignees

@adizere adizere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hermes may send timeouts for packets that have not expired yet
2 participants
@ancazamfir @adizere