Upgrade to IBC-go v2 #1582

adizere · 2021-11-22T09:37:34Z

Description

IBC-go V2 is already live on some networks.
Hub-4 plans to upgrade to ibc-go v2 on December 13th: gov proposal draft is here: https://hackmd.io/@okwme/vega-upgrade

Other variant should be ChanOpenTry (we don't do anything in any other case..)
enable (true) for gaia tests with v6.0.0 to catch the error

For contributor use:

Added a changelog entry, using unclog.
If applicable: Unit tests written, added test to CI.
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Updated relevant documentation (docs/) and code comments.
Re-reviewed Files changed in the Github PR explorer.

…ryAppVersionRequest in cosmos.rs

relayer-cli/src/commands/tx/channel.rs

relayer/src/channel.rs

relayer/src/channel/version.rs

relayer/src/chain/handle.rs

…_channel (called for ack and confirm) as version validation is not done here

damiannolan · 2021-12-07T17:28:19Z

Thank you for the quick updates to this branch, very much appreciated! ❤️ With the latest changes, the handshake flow for interchain-accounts is working pretty seemlessly, and have had success with account registration!

I am still trying to debug some issues wrt. executing an interchain-accounts tx. I am seeing the following error in hermes logs upon packet recv: account sequence mismatch, expected 7 got 6: incorrect account sequence.

I had experienced this before and it was a case that the validator address had been used for the relayer wallet. However, in this case I've set it up such that there is separate wallets being used. Will continue with this tomorrow!
Thanks once again for this 🙌

Edit: A brief update on this: after restarting hermes the packet is received on chain B and executes the interchain-accounts tx successfully.

Edit 2: I spent this morning refactoring the scripts in the interchain-accounts auth module repo. I created a number of extra accounts so that I could keep all tx execution wrt. to intertx and ica completely separate from validator accs and relayer wallets. Had great success with this and it resolved the account sequence mismatch error I was experiencing. Account registration via the handshake flow and tx execution is now working nicely :)

relayer/src/channel.rs

…l is already specified

damiannolan · 2021-12-14T11:17:29Z

Ack: When tested with the changes in ibc-go #624 channel workers are now picking up events emitted from ICS-27 handshake initiation and correctly finishing them!

Looks good 🙌 LGTM when you are happy with it :)

romac

🚀

adizere · 2021-12-14T13:51:58Z

modules/src/core/ics04_channel/channel.rs

@@ -300,8 +300,8 @@ impl From<Counterparty> for RawCounterparty {
 #[derive(Clone, Copy, Debug, PartialEq, Eq, Deserialize, Serialize)]
 pub enum Order {
    None = 0,
-    Unordered,
-    Ordered,
+    Unordered = 1,


* Proto generation result aligned w/ ibc-go v2 * Registered port.v1.rs as a proto file. Initial sketch for calling QueryAppVersionRequest in cosmos.rs * Cleanup ICS04 version. Add separate versions in channel.rs * Using ics04::Version; module_version -> app_version * add version resolve() method * query_app_version with a Grpc request * Separate version for each ChannelSide * Version domain type in the ibc module * Clippy problems re: Version newtype * First iteration of a solution to negotiate versions. Big TODO left * Refactor dst_app_version into the version mod * Bump ibc compat to v2 * Fixed proposed version * More disciplined logs * Debugging tx raw chan open try * fmt * Formatting * Remove redundant imports * Formatting * Fixes cf. Romain's review. * Only resolve version for init and try, remove from validated_expected_channel (called for ack and confirm) as version validation is not done here * Introduce Version::empty() * Attempt to catch gaia E2E errors w/ continue-on-error: false * More accurate naming: Other -> ChanOpenTry variant * Avoid fetching the default channel by port when there a source channel is already specified * Introduced domain-type request * changelog * Use explicit i32 values for the `Order` enum Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>

adizere added 18 commits November 2, 2021 17:32

Proto generation result aligned w/ ibc-go v2

13c9eae

Registered port.v1.rs as a proto file. Initial sketch for calling Que…

402b36f

…ryAppVersionRequest in cosmos.rs

Merge branch 'master' into adi/ibcgo_v2

65ac629

Cleanup ICS04 version. Add separate versions in channel.rs

1006e6b

Using ics04::Version; module_version -> app_version

f493328

add version resolve() method

dd2bfba

query_app_version with a Grpc request

cc4f978

Separate version for each ChannelSide

644725d

Version domain type in the ibc module

222a03a

Clippy problems re: Version newtype

0314b2f

Merge branch 'master' into adi/ibcgo_v2

6fe686a

First iteration of a solution to negotiate versions. Big TODO left

95ec54e

Refactor dst_app_version into the version mod

9903856

Bump ibc compat to v2

6f49ce5

Fixed proposed version

ed49e01

More disciplined logs

8613ed3

Debugging tx raw chan open try

27a9cc2

fmt

5c1d5b3

romac assigned romac, adizere and ancazamfir Nov 24, 2021

adizere marked this pull request as ready for review November 24, 2021 14:58

adizere requested review from ancazamfir and romac as code owners November 24, 2021 14:58

romac added 3 commits November 24, 2021 17:24

Merge branch 'master' into adi/ibcgo_v2

c20c190

Formatting

800ef7f

Remove redundant imports

f629e1d

adizere commented Nov 25, 2021

View reviewed changes

relayer-cli/src/commands/tx/channel.rs Show resolved Hide resolved

romac added 2 commits November 26, 2021 11:10

Merge branch 'master' into adi/ibcgo_v2

16253f6

Formatting

241d221