Delete packet commitment instead of acknowledgement in acknowledgePacket

[hu55a1n1]

Closes: cosmos/ibc-rs#66

Description

See processing-acknowledgements ->

function acknowledgePacket(
  packet: OpaquePacket,
  acknowledgement: bytes,
  proof: CommitmentProof,
  proofHeight: Height,
  relayer: string): Packet {

    // ...
    
    // delete our commitment so we can't "acknowledge" again
    provableStore.delete(packetCommitmentPath(packet.sourcePort, packet.sourceChannel, packet.sequence))  // <---- here

    // return transparent packet
    return packet
}

---

For contributor use:

• Added a changelog entry, using unclog.
• If applicable: Unit tests written, added test to CI.
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Updated relevant documentation (docs/) and code comments.
• Re-reviewed Files changed in the Github PR explorer.

[hu55a1n1]

Hi @livelybug! I'm unable to test this with your 'Steps to Reproduce' as I haven't worked with substrate chains before. Can you please confirm if this fixes cosmos/ibc-rs#66?

[livelybug]

Hi @livelybug! I'm unable to test this with your 'Steps to Reproduce' as I haven't worked with substrate chains before. Can you please confirm if this fixes cosmos/ibc-rs#66?

Yes, I can confirm.
The same fix was applied here and tested.

[romac]

🌻