-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protos to IBC v3.0.0-rc.0 and Cosmos SDK v0.45.1 #1825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super! Left a couple of suggestions for further cleanup, but I think we're pretty much ready.
We should also bump up the IBC_GO_MODULE_VERSION_REQ
to match ibc-go v3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, awesome work Romain!
I think we still have 3 sets of COSMOS_IBC|SDK_COMMIT
files, would be cool to reduce the redundancy there.
If we decide to do a 0.11.1 release then maybe merge this PR only after the release.
In IBC v2, relayers would query the `NegotiateAppVersion` endpoint before calling `ChanOpenTry`. Applications would then need to verify that the passed in version was correct. As of IBC v3, applications will perform this version negotiation during the channel handshake, thus removing the need for the relayer to query the version.
3918216
to
c26cdf5
Compare
Done :) |
We might have moved a bit too fast with upgrading the files: https://github.com/cosmos/ibc-go/releases/tag/v3.0.0-beta1. I think we should regenerate the files from v3-beta1, or maybe even better, wait it out until v3 comes out (towards end of Febr)?
|
Sure, that was expected. We don't want to merge this before v3 is out anyway :) |
* Unify error messages casing * Revert unrelated change * Fix capitalization of CheckTx
* Use empty version for `ChanOpenInit` when port is non-standard and source channel version for `ChanOpenTry` steps * Remove unused error variant * Remove misleading comment * Add changelog entry
e2d2ca4
to
d71ea62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We'll do more extensive manual testing, and also give the master branch for testing to a couple of operators once this is merged.
Great work Romain!
Closes: cosmos/ibc-proto-rs#5
Description
Update Protocol Buffers definitons to Cosmos SDK v0.45.1 et IBC v3.0.0-rc.0
Remove channel version negotiation step during channel handshake (done in Handle non-standard ports in channel handshake #1840)
Handle non-standard ports in channel handshake (done in Handle non-standard ports in channel handshake #1840)
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.