Add two more health checks: tx indexing enabled and historical entries #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adizere
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Looks good conceptually. I didn't test the historical_entries check as that is unclear how to achieve. I'll let @ancazamfir weigh in on the changes relative to that check.
A basic test against the tx_index checkup works fine!
2022-02-17T15:26:16.009748Z INFO ThreadId(01) [ibc-0] performing health check...
2022-02-17T15:26:16.022815Z WARN ThreadId(01) Health checkup for chain 'ibc-0' failed
2022-02-17T15:26:16.022854Z WARN ThreadId(01) Reason: transaction indexing for chain 'ibc-0' is disabled (node_info.other.tx_indexis off)
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
informalsystems#1863) * Add `CosmosSdkChain::historical_entries()` method * Add health check for historical entries * Improve tx indexing check * Fix block_on within block_on * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1388
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.