Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection delay test #1960

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Add connection delay test #1960

merged 4 commits into from
Mar 29, 2022

Conversation

soareschen
Copy link
Contributor

Supercedes #1950 and closes: #1836

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@adizere
Copy link
Member

adizere commented Mar 29, 2022

@hu55a1n1: This is already used in #1917.

hu55a1n1
hu55a1n1 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@hu55a1n1 hu55a1n1 merged commit be7e06f into master Mar 29, 2022
@hu55a1n1 hu55a1n1 deleted the soares/test-connection-delay branch March 29, 2022 18:58
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@soareschen
Add connection delay test (informalsystems#1960)
1972a91 
* Add connection delay test

* Fix merge error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hu55a1n1 hu55a1n1 hu55a1n1 approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees

@hu55a1n1 hu55a1n1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test the connection delay feature [meta]
3 participants
@soareschen @adizere @hu55a1n1