Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform integration test with ibc-go simapp on CI #1996

Merged
merged 5 commits into from
Mar 23, 2022
Merged

Perform integration test with ibc-go simapp on CI #1996

merged 5 commits into from
Mar 23, 2022

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Mar 22, 2022 •
edited
Loading

Closes #1967.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen force-pushed the soares/ci-ibc-go-simapp branch from d3b0a34 to 2a4d835 Compare March 22, 2022 15:36
@soareschen soareschen force-pushed the soares/ci-ibc-go-simapp branch from 2a4d835 to 8c2cffc Compare March 22, 2022 15:43
This was referenced Mar 22, 2022
Closed
Closed
Merged
@soareschen soareschen marked this pull request as ready for review March 22, 2022 19:10
@soareschen
Copy link
Contributor Author

@romac I tried running test_ica_filter_default with simd, but it don't support the intertx command. Do you know if there is any way we can run the ICA test using simd?

@romac
Copy link
Member

romac commented Mar 22, 2022

afaik it's only possible with icad at the moment

@soareschen soareschen merged commit 20e5fe6 into master Mar 23, 2022
@soareschen soareschen deleted the soares/ci-ibc-go-simapp branch March 23, 2022 12:48
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@soareschen
Perform integration test with ibc-go simapp on CI (informalsystems#1996)
b3faf96 
* Perform integration test with ibc-go simapp on CI

* Add ibc-go-ics29-simapp

* Bump

* Use Cosmos.nix master, remove gaia4 EOL

* Use gaia6-ordered from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop Gaia fork with ICS29 Fee Middleware enabled
2 participants
@soareschen @romac