Remove the OCap system #2186
Merged
Remove the OCap system #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
requested review from
hu55a1n1,
adizere,
ancazamfir and
romac
as code owners
adizere
approved these changes
May 10, 2022
| @@ -18,6 +18,31 @@ Implementation of the Inter-Blockchain Communication Protocol ([IBC]) module. | |||
|
|
|||
| See documentation on [docs.rs][docs-link]. | |||
|
|
|||
| ## Divergence from the Interchain Standards (ICS) | |||
There was a problem hiding this comment.
Tip-top, thanks for taking the care to describe this!
hu55a1n1
reviewed
May 10, 2022
| Test { | ||
| name: "Good parameters".to_string(), | ||
| ctx: context | ||
| .with_client(&ClientId::default(), client_height) | ||
| .with_connection(ConnectionId::default(), connection_end) | ||
| .with_port_capability(packet.destination_port.clone()) | ||
| .with_port(packet.destination_port.clone()) |
There was a problem hiding this comment.
IIUC, I don't think we need to set a port mapping to test handshakes, so we should be able to remove most of them.
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Remove capabilities * changelog * Start documenting where we diverge from spec * Update modules/README.md Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com> * remove MockContext::with_port * cippy tests Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: cosmos/ibc-rs#45
Closes: #2116
Description
This PR removes everything "object capability" in the modules. Notably, there is now only 1 function to bind a module to a port (
PortKeeper::bind_module_to_port(module_id, port_Id)), and 1 function to lookup a module by port (PortReader::lookup_module_by_port(port_id)).We currently don't support transferring ownership of a port or releasing a port.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.