Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo-audit daily or when dependencies have changed #22

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

romac
Copy link
Member

@romac romac commented Mar 6, 2020

Closes: N/A

Description

Change the Audit GitHub Action to run daily, and on pushes but only when dependencies have actually changed. This should speed up CI quite a bit as this action takes a considerable amount of time to complete.

The config comes from informalsystems/tendermint-rs#144 (comment)


For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@romac romac requested a review from ancazamfir as a code owner March 6, 2020 10:55
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason this uses v1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's a mistake on my part, I blindly copy-pasted the config file used above. Will change it back to v2. Thanks for noticing!

@romac romac merged commit a72453f into master Mar 9, 2020
@romac romac deleted the romac/gh-audit-deps branch March 9, 2020 12:38
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…ems#22)

* Run cargo-audit daily and when dependencies have changed

See informalsystems/tendermint-rs#144 (comment)

* Change actions/checkout back to v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants