Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MBT tests on CI due to flakiness #2253

Merged
merged 1 commit into from
Jun 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -199,15 +199,16 @@ jobs:
- uses: actions-rs/cargo@v1
with:
command: test
args: -p ibc-integration-test --no-fail-fast --no-run
- env:
RUST_LOG: debug
RUST_BACKTRACE: 1
NO_COLOR_LOG: 1
run: |
nix shell \
.#${{ matrix.gaiad }} \
.#apalache \
-c cargo \
test -p ibc-integration-test --features mbt --no-fail-fast -- \
--nocapture --test-threads=1 mbt
args: -p ibc-integration-test --features mbt --no-fail-fast --no-run
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still compile the test with mbt feature to ensure that the MBT code still type checks with new changes.

# Disable running MBT tests until flakiness is addressed
# - env:
# RUST_LOG: debug
# RUST_BACKTRACE: 1
# NO_COLOR_LOG: 1
# run: |
# nix shell \
# .#${{ matrix.gaiad }} \
# .#apalache \
# -c cargo \
# test -p ibc-integration-test --features mbt --no-fail-fast -- \
# --nocapture --test-threads=1 mbt
2 changes: 1 addition & 1 deletion relayer-cli/src/commands/query/channel_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ impl Runnable for QueryChannelClientCmd {

match chain.query_channel_client_state(QueryChannelClientStateRequest {
port_id: self.port_id.clone(),
channel_id: self.channel_id.clone(),
channel_id: self.channel_id,
}) {
Ok(cs) => Output::success(cs).exit(),
Err(e) => Output::error(format!("{}", e)).exit(),
Expand Down