Update wallet_balance metric to f64 instead of u64
#2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljoss17
requested review from
adizere,
romac,
seanchen1991 and
ancazamfir
as code owners
ljoss17
changed the title
wallet_balance metric to f64 instead of u64
ljoss17
changed the title
wallet_balance metric to f64 instead of u64wallet_balance metric to f64 instead of u64
romac
requested changes
Jul 20, 2022
| %balance.amount, denom = %balance.denom, account = %key.account, | ||
| "Error parsing amount into f64 and therefore won't be reported to telemetry" | ||
| ); | ||
| warn!( |
There was a problem hiding this comment.
Let's remove this and make the trace above a warning instead.
There was a problem hiding this comment.
Handling the parsing error has been updated to only be a warning
…precision due to conversion to f64
6 tasks
romac
reviewed
Jul 20, 2022
romac
approved these changes
Jul 20, 2022
romac
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2381
Description
This PR is an alternative solution to the PR #2425.
Instead of dividing the
wallet_balancemetric by a configurable order of magnitude, this PR updates the metric type fromu64tof64.As
f64::MAXis bigger thanU256::MAXthis solves the overflow problem without the need to divide thewallet_balance, thus does not introduce a new configurable value.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.