Add --show-counterparty flag to hermes query channels
#2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 25, 2022 19:19
AlianBenabdallah
requested review from
mzabaluev,
romac and
ancazamfir
as code owners
romac
reviewed
Jul 26, 2022
.changelog/unreleased/features/ibc-relayer-cli/2431-show-counterparty.md
Outdated
Show resolved
Hide resolved
romac
reviewed
Jul 26, 2022
Co-authored-by: Romain Ruetschi <romain@informal.systems>
romac
reviewed
Jul 26, 2022
| output.iter().try_for_each(|pretty_print| { | ||
| write!( | ||
| f, | ||
| "\n{}: {}/{} --- {}: {}/{}", |
There was a problem hiding this comment.
To make things slightly prettier, let's use a unicode arrow instead of ---?
For instance ⟷
ibc-1: transfer/channel-0 ⟷ ibc-0: transfer/channel-0
ibc-1: transfer/channel-1 ⟷ ibc-2: transfer/channel-1
There was a problem hiding this comment.
Unicode arrows are pretty small on my console :
There was a problem hiding this comment.
Wonder why your terminal does that though? Perhaps it's the font?
There was a problem hiding this comment.
I have no idea. I could push a new version with the double arrow if you want to try with your terminal as well.
There was a problem hiding this comment.
Interesting, they also render funny in iTerm on macOS.
There was a problem hiding this comment.
Maybe we can use another emoji ?
romac
changed the title
--show-counterparty flag for hermes query channels--show-counterparty flag to hermes query channels
added 3 commits
July 26, 2022 12:39
.changelog/unreleased/features/ibc-relayer-cli/2429-show-counterparty.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Chen <seanchen11235@gmail.com>
…erparty.md Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Co-authored-by: Sean Chen <seanchen11235@gmail.com>
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…stems#2463) * added --show-counterparty flag * added test * changelog entry and fmt * Rename 2431-show-counterparty.md to 2429-show-counterparty.md * Update relayer-cli/src/commands/query/channels.rs Co-authored-by: Romain Ruetschi <romain@informal.systems> * Update 2429-show-counterparty.md * Update 2429-show-counterparty.md * fix typo * fixed tests * update doc * Update relayer-cli/src/commands/query/channels.rs Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update .changelog/unreleased/features/ibc-relayer-cli/2429-show-counterparty.md Co-authored-by: Sean Chen <seanchen11235@gmail.com> * Update relayer-cli/src/commands/query/channels.rs Co-authored-by: Sean Chen <seanchen11235@gmail.com> * modified error handling * modify error handling Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2429
Description
This PR introduces a new flag for
hermes query channelswhich outputs every channel along with its corresponding port, and the counterparty chain's id in a pretty way.Example with 3 chains:
Filtering is also working :
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.