connection msgs.rs split #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adizere
approved these changes
Sep 30, 2020
| @@ -5,7 +5,7 @@ use crate::ics03_connection::error::{Error, Kind}; | |||
| use crate::ics03_connection::handler::verify::{check_client_consensus_height, verify_proofs}; | |||
| use crate::ics03_connection::handler::ConnectionEvent::ConnOpenTry; | |||
| use crate::ics03_connection::handler::ConnectionResult; | |||
| use crate::ics03_connection::msgs::MsgConnectionOpenTry; | |||
| use crate::ics03_connection::msgs::conn_open_try::MsgConnectionOpenTry; | |||
There was a problem hiding this comment.
In a separate, later PR, we can consider using the trick Greg used in ibc-proto, to shorten the import paths. So instead of
use crate::ics03_connection::msgs::conn_open_try::MsgConnectionOpenTry;
we could get
use crate::ics03_connection::msgs::MsgConnectionOpenTry;
by using in msgs.rs something like:
mod conn_open_try;
pub use conn_open_try::*;
This improvement could benefit multiple other parts of our codebase, not just msgs. I will open an issue for this later on.
There was a problem hiding this comment.
Agreed. I tried this briefly but couldn't make it work and ran out of time.
There was a problem hiding this comment.
Ah in fact there is already an issue open for this: informalsystems/ibc-rs#186. We'll solve this later!
This was referenced Oct 8, 2020
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Split connection msgs * Cleanup and added From impls and tests for all messages * forgotten merge conflict resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: informalsystems/ibc-rs#112
Description
Split the
ics03_connection/msgs.rs, addedFromfor all connection messages and testsFor contributor use:
docs/) and code commentsFiles changedin the Github PR explorer