Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split gm out of the repo #2775

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Split gm out of the repo #2775

merged 5 commits into from
Oct 27, 2022

Conversation

harveenSingh
Copy link
Contributor

@harveenSingh harveenSingh commented Oct 27, 2022 •
edited
Loading

Closes: #2754

Description

Removed gm folder and it's contents
Updated the guide to reflect new gm repo

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@harveenSingh harveenSingh marked this pull request as ready for review October 27, 2022 15:59
@seanchen1991 seanchen1991 merged commit 3aba0ff into master Oct 27, 2022
@seanchen1991 seanchen1991 deleted the hs/split-gm branch October 27, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanchen1991 seanchen1991 seanchen1991 approved these changes

Assignees

@seanchen1991 seanchen1991

@harveenSingh harveenSingh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split gm out of the hermes repo
2 participants
@harveenSingh @seanchen1991