Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust version to 1.65.0 #2817

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Update Rust version to 1.65.0 #2817

merged 4 commits into from
Nov 7, 2022

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Nov 4, 2022

Closes: #2818

Description

Update the minimum version bound of Rust to 1.65. This will allow us to make use of new language features in Rust, most notably Generic Associated Types.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the MSRV in README.md.
The full checklist is in an issue template, which itself needs to be updated because some items no longer apply.

@soareschen soareschen mentioned this pull request Nov 4, 2022
7 tasks
@soareschen
Copy link
Contributor Author

Please also update the MSRV in README.md. The full checklist is in an issue template, which itself needs to be updated because some items no longer apply.

Done.

@romac romac merged commit 01a39ca into master Nov 7, 2022
@romac romac deleted the soares/rust-1.65 branch November 7, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rust version to 1.65.0
4 participants