Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dumping Prometheus metrics to JSON #2843

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Add support for dumping Prometheus metrics to JSON #2843

merged 2 commits into from
Nov 29, 2022

Conversation

romac
Copy link
Member

@romac romac commented Nov 8, 2022 •
edited
Loading

Closes: #2890

Description

PR author checklist:

  • Linked to GitHub issue.
  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac force-pushed the romac/json-telemetry branch 2 times, most recently from 7b3f6e7 to 3f8c2b6 Compare November 9, 2022 08:40
@romac romac requested a review from ljoss17 November 23, 2022 11:46
@romac romac marked this pull request as ready for review November 28, 2022 14:21
adizere
adizere approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle looks good. I only did a couple of sanity (manual test) checks of the JSON output.

If there is a use-case on how these would be consumed that is more specific, then might be good to document it in the guide. Thanks Romain!

crates/telemetry/src/encoder.rs Show resolved Hide resolved
@romac
Copy link
Member Author

romac commented Nov 29, 2022

If there is a use-case on how these would be consumed that is more specific, then might be good to document it in the guide. Thanks Romain!

I don't have a specific use case right now, or at least not fleshed out enough that it would be worth documenting, but I'll keep that in mind for when that's the case.

@romac romac merged commit 102f979 into master Nov 29, 2022
@romac romac deleted the romac/json-telemetry branch November 29, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ljoss17 ljoss17 Awaiting requested review from ljoss17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for dumping Prometheus metrics to JSON
2 participants
@romac @adizere