Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup mock context for ICS2 #305

Merged
merged 12 commits into from
Oct 15, 2020
Merged

Cleanup mock context for ICS2 #305

merged 12 commits into from
Oct 15, 2020

Commits on Oct 12, 2020

  1. ICS2 create_client handler adapted to global mock context.

    @adizere
    adizere committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    41aa2c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Cleaning update_client.rs

    @adizere
    adizere committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    d10f5a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into adi/296_ics2_cleanup

    @adizere
    adizere committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    19b500b View commit details
    Browse the repository at this point in the history

  3. Testing w/ dispatch() instead of process()

    @adizere
    adizere committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    cb98847 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. More asserts, avoided explicit type annotations.

    @adizere
    adizere committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    d012f6c View commit details
    Browse the repository at this point in the history

  2. Wrapper around parametrized & remark about invalid context.

    @adizere
    adizere committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    a6d3d2e View commit details
    Browse the repository at this point in the history

  3. Switched from 'result' to 'output'

    @adizere
    adizere committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    c1f8a4f View commit details
    Browse the repository at this point in the history

  4. Fixes after Anca's detailed comments & chat

    @adizere
    adizere committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    fbbde8e View commit details
    Browse the repository at this point in the history

  5. Reverted the renaming of ClientEvent enum members.

    @adizere
    adizere committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    ba81443 View commit details
    Browse the repository at this point in the history

  6. Apply Anca's suggestions to simplify imports in ICS2 handler 

    Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
    @adizere @ancazamfir
    adizere and ancazamfir committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    53dec60 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Merge branch 'master' into adi/296_ics2_cleanup

    @adizere
    adizere committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    152a8b8 View commit details
    Browse the repository at this point in the history

  2. Post-merge re-fixes.

    @adizere
    adizere committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    831b378 View commit details
    Browse the repository at this point in the history