Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ccv_consumer_chain flag and use the ICS param query when enabled #3174

Merged
merged 7 commits into from
Apr 12, 2023

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Mar 16, 2023

Closes: #3125

Description

  • removed unbonding_period from the config and added ccv_consumer_chain
  • use the ICS gRPC to get the consumer chain parameters

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac changed the title Add ccv_consumer_chain flag and use the ICS param query when enabled Add ccv_consumer_chain flag and use the ICS param query when enabled Apr 12, 2023
@romac romac marked this pull request as ready for review April 12, 2023 09:06
@romac romac merged commit 61424e0 into master Apr 12, 2023
@romac romac deleted the anca/3125-ics-params branch April 12, 2023 09:24
@romac romac restored the anca/3125-ics-params branch April 12, 2023 17:11
@romac romac deleted the anca/3125-ics-params branch April 26, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hermes uses wrong unbonding period or fails for ICS Consumer chains
2 participants