-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set channel version at the application level #3267
Conversation
Perhaps we should actually keep the counterparty version set in the OpenTry message and see if that fixes some tests. The ordered channel test is apparently using an old version of ibc-go (v3) which seems to require the version at the open init step. We should see if we can update it to a newer version. |
Nevermind, looks like pretty much all tests are failing, even on Gaia 8. Maybe we should just drop this PR then, or at least clarify the expected behavior with the ibc-go team. |
It seems that the version which is deprecated is the one in the |
Looks like gaia8 (and likely other chains using the same ibc-go version) still expects a version to be set at chan open init, so perhaps we should keep doing that as well. |
Given the resulting change I wonder if we shouldn't just drop the PR altogether? Do we foresee any issues with setting the try version to its init counterpart? If not then let's drop it. |
I agree, the deprecated version in the |
Closes: #3213
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.