Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to configure the rate at which to refresh clients #3402

Merged
merged 12 commits into from
Jan 5, 2024
Merged

Add setting to configure the rate at which to refresh clients #3402

merged 12 commits into from
Jan 5, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jun 6, 2023 •
edited
Loading

Closes: #3397

Description

Add a client_refresh_rate setting to specify the rate at which to refresh clients referencing this chain, as a fraction of their trusting period.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac mentioned this pull request Jun 6, 2023
Closed
5 tasks
@romac romac changed the title Add setting to configure the client refresh rate Add setting to configure the interval at which to refresh clients Sep 27, 2023
@romac romac changed the title Add setting to configure the interval at which to refresh clients Add setting to configure the rate at which to refresh clients Sep 27, 2023
@romac
Merge branch 'master' into romac/3397-lc-refresh
f80ecc1
@romac
Merge branch 'master' into romac/3397-lc-refresh
8393c8f
@romac
Allow deserializing a trust threshold as a string or a struct
b55ce20 
All these formats are allowed and equivalent:

- trust_threshold = '2/3'
- trust_threshold = { numerator = 2, denominator = 3 }
- trust_threshold = { numerator = '2', denominator = '3' } (for backward compat)
@romac
Fix clippy warnings
465291b
@romac
Keep serializing as a map
bf42710
@romac
Remove dead code
df8025f
@romac romac marked this pull request as ready for review January 3, 2024 15:05
@romac romac requested a review from ljoss17 January 3, 2024 15:05
ljoss17
ljoss17 requested changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small nits

crates/relayer/src/config.rs Outdated Show resolved Hide resolved
crates/relayer/src/worker/client.rs Outdated Show resolved Hide resolved
romac and others added 2 commits January 5, 2024 10:44
@romac @ljoss17
Fix typo
35f12bb 
Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
Signed-off-by: Romain Ruetschi <github@romac.me>
@romac @ljoss17
Fix default trust threshold to 2/3
977f1e0 
Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
Signed-off-by: Romain Ruetschi <github@romac.me>
@romac romac requested a review from ljoss17 January 5, 2024 09:45
ljoss17
ljoss17 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@romac romac merged commit 3ec02fe into master Jan 5, 2024
34 checks passed
@romac romac deleted the romac/3397-lc-refresh branch January 5, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make light client refresh window configurable
2 participants
@romac @ljoss17