Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable listen command with pull event source #3502

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Enable listen command with pull event source #3502

merged 4 commits into from
Aug 17, 2023

Conversation

romac
Copy link
Member

@romac romac commented Jul 25, 2023 •
edited
Loading

Closes: #3501

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from ljoss17 August 3, 2023 12:36
ljoss17
ljoss17 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits but looks good to me!

crates/relayer-cli/src/commands/listen.rs Outdated Show resolved Hide resolved
crates/relayer-cli/src/commands/listen.rs Outdated Show resolved Hide resolved
@romac @ljoss17
Apply suggestions from code review
f2b5b5c 
Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
Signed-off-by: Romain Ruetschi <github@romac.me>
@ljoss17 ljoss17 merged commit d9813d1 into master Aug 17, 2023
40 checks passed
@ljoss17 ljoss17 deleted the romac/listen-rpc branch August 17, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable listen command with pull event source
2 participants
@romac @ljoss17