Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component graph design pattern to manage components #3528

Merged
merged 16 commits into from
Aug 9, 2023

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Aug 9, 2023

Part of: informalsystems/hermes-sdk#9

Description

This PR introduces the component graph design pattern described in informalsystems/hermes-sdk#9 to allow for more flexible customization of the relayer component graph.

The work for removing the all-in-one traits will be done in a separate PR. As a transition, we have the one-for-all traits implement HasComponents, so that the component graph is derived separately from the one-for-all traits.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen merged commit aa80935 into soares/relayer-next Aug 9, 2023
48 of 51 checks passed
@soareschen soareschen deleted the soares/component-graph branch August 9, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant