Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one-for-all runtime constructs #3542

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

soareschen
Copy link
Contributor

Part of: informalsystems/hermes-sdk#9

Description

This PR removes the OfaRuntime construct and have TokioRuntimeContext implement the runtime traits directly. This is part of an ongoing effort to remove all one-for-all traits and have the concrete contexts implement the individual traits directly.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen changed the base branch from master to soares/relayer-next August 15, 2023 19:52
@soareschen soareschen added the O: relayer-next Objective: work toward relayer v2 label Aug 15, 2023
@soareschen soareschen merged commit 4238d6c into soares/relayer-next Aug 16, 2023
48 of 51 checks passed
@soareschen soareschen deleted the soares/runtime-refactor branch August 16, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: relayer-next Objective: work toward relayer v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant