Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove one-for-all transaction constructs #3543

Merged
merged 15 commits into from
Aug 16, 2023
Merged

Remove one-for-all transaction constructs #3543

merged 15 commits into from
Aug 16, 2023

Conversation

soareschen
Copy link
Contributor

Part of: informalsystems/hermes-sdk#9

Description

This PR removes the OfaTxContext trait and have CosmosTxContext implement the transaction context traits directly.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen changed the base branch from master to soares/relayer-next August 16, 2023 18:49
@soareschen soareschen added the O: relayer-next Objective: work toward relayer v2 label Aug 16, 2023
@soareschen soareschen merged commit db6262d into soares/relayer-next Aug 16, 2023
47 of 51 checks passed
@soareschen soareschen deleted the soares/refactor-tx-context branch August 16, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
O: relayer-next Objective: work toward relayer v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soareschen