Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce component graph constraint closure #3588

Merged
merged 15 commits into from
Sep 5, 2023

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Sep 5, 2023

Description

The implementation of the component graph design pattern makes it difficult for new context implementations such as #3566 to debug constraint errors on missing trait implementation.

To ease the use of component graphs, we introduce closure traits like CanUseDefaultRelayComponents to assert that a given relay context is expected to implement all dependencies that are required for the default relay component graph to work.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen added the O: relayer-next Objective: work toward relayer v2 label Sep 5, 2023
@soareschen soareschen marked this pull request as ready for review September 5, 2023 17:49
@soareschen soareschen merged commit 8dec7c5 into soares/relayer-next Sep 5, 2023
33 of 52 checks passed
@soareschen soareschen deleted the soares/component-graph-constraints branch September 5, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: relayer-next Objective: work toward relayer v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant