Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ibc-go v8 to integration tests #3694

Merged
merged 25 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f1b98d8
Add simapp v8 to CI jobs
ljoss17 Nov 13, 2023
a14e05e
Add simapp v8 to nix flake
ljoss17 Nov 13, 2023
b9b9373
Handle CLI breaking changes of Cosmos SDK v0.50 in test bootstrap
ljoss17 Nov 13, 2023
d57911e
Handle genesis config 'voting_perdiod' and CLI 'query txs' changes fo…
ljoss17 Nov 13, 2023
3829b80
Merge branch 'master' into luca_joss/ibc-go-v8-compatibility
ljoss17 Nov 13, 2023
29b16ad
Use 'MsgSubmitProposal' instead of deprecated 'UpgradeProposal' to in…
ljoss17 Nov 14, 2023
7f934b3
Update 'tx upgrade-chain' CLI template
ljoss17 Nov 14, 2023
4b54a54
Fix 'tx chain-upgrade' tests
ljoss17 Nov 14, 2023
d76e93a
Update chain upgrade for compatibility between different ibc-go versions
ljoss17 Nov 15, 2023
341f356
Improve assertion for client upgrade tests
ljoss17 Nov 16, 2023
6111d1e
Update ibc-proto-rs to v0.39.0
ljoss17 Nov 16, 2023
a92ef0f
Add changelog entry
ljoss17 Nov 16, 2023
b9102ed
Fix and improve guide section for client upgrade
ljoss17 Nov 16, 2023
1fece30
Wait before querying client state for client upgrade tests
ljoss17 Nov 16, 2023
2b11803
Apply suggestions from code review
ljoss17 Nov 16, 2023
5ab4845
Rename method 'ibc_version()' to 'version_specs'
ljoss17 Nov 16, 2023
3287ddf
Extract the verification of legacy version in a method
ljoss17 Nov 16, 2023
a8434f6
Implement 'FromStr' instead of 'TryFrom<String>' for 'ProposalStatus'
ljoss17 Nov 16, 2023
b7a7af6
Fix cargo-doc warning
ljoss17 Nov 16, 2023
056d778
Add changelog entry for CLI
ljoss17 Nov 16, 2023
1ce8423
Change the '--gov-account' flag as optional but will fail if trying t…
ljoss17 Nov 16, 2023
6602a16
Update guide
ljoss17 Nov 16, 2023
10225c6
Move and update changelog entry for CLI
ljoss17 Nov 16, 2023
f135f41
Return a 'Specs' struct in 'version_specs()' method
ljoss17 Nov 16, 2023
6cc9538
Fix clippy errors
ljoss17 Nov 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Add a `--gov-account` option to `hermes tx upgrade-chain` to specify the
authority account used to sign upgrade proposal for chains running IBC-Go v8+.
([\#3696](https://github.com/informalsystems/hermes/issues/3696))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Use legacy `UpgradeProposal` or newer `MsgIbcSoftwareUpgrade` message when upgrading
a chain depending on whether the chain is running IBC-Go v8 or older.
([\#3696](https://github.com/informalsystems/hermes/issues/3696))
romac marked this conversation as resolved.
Show resolved Hide resolved
9 changes: 9 additions & 0 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ jobs:
- package: ibc-go-v7-simapp
command: simd
account_prefix: cosmos
- package: ibc-go-v8-simapp
command: simd
account_prefix: cosmos
- package: wasmd
command: wasmd
account_prefix: wasm
Expand Down Expand Up @@ -157,6 +160,9 @@ jobs:
- package: ibc-go-v7-simapp
command: simd
account_prefix: cosmos
- package: ibc-go-v8-simapp
command: simd
account_prefix: cosmos
steps:
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v22
Expand Down Expand Up @@ -206,6 +212,9 @@ jobs:
- package: ibc-go-v7-simapp
command: simd
account_prefix: cosmos
- package: ibc-go-v8-simapp
command: simd
account_prefix: cosmos
- package: migaloo
command: migalood
account_prefix: migaloo
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/multi-chains.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ jobs:
- package: ibc-go-v7-simapp
command: simd
account_prefix: cosmos
- package: ibc-go-v8-simapp
command: simd
account_prefix: cosmos
- package: wasmd
command: wasmd
account_prefix: wasm
Expand Down
105 changes: 60 additions & 45 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/chain-registry/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ description = """

[dependencies]
ibc-relayer-types = { version = "0.26.1", path = "../relayer-types" }
ibc-proto = { version = "0.38.0", features = ["serde"] }
ibc-proto = { version = "0.39.0", features = ["serde"] }
tendermint-rpc = { version = "0.34.0", features = ["http-client", "websocket-client"] }

async-trait = "0.1.72"
Expand Down
Loading
Loading