Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch the light block at trusted_height + 1 when detecting misbehavior #3698

Closed
wants to merge 3 commits into from
Closed

Fetch the light block at trusted_height + 1 when detecting misbehavior #3698

wants to merge 3 commits into from

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Nov 16, 2023 •
edited
Loading

Closes: #3697

Description

Please see the issue for the details.

This PR changes to fetch the light block at trusted_height+1 not trust_height in detect_misbehavior.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac changed the title fetch the light block at trusted_height+1 when detecting misbehavior Fetch the light block at trusted_height + 1 when detecting misbehavior Dec 4, 2023
romac
romac approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fix! This indeed does seem to solve some issues we have seen on testnets.

@romac
Copy link
Member

romac commented Dec 13, 2023

As I cannot push to your branch, I will close this and open a new PR with your commits and add changelog entry.

@romac romac closed this Dec 13, 2023
@romac romac mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about trusted_validator_set in detect_misbehavior
2 participants
@beer-1 @romac