Add support for Namada #3705
Add support for Namada #3705
Conversation
….1-namada Update yuji 1.7.1 namada
crates/relayer/src/chain/namada.rs
Outdated
| } | ||
|
|
||
| impl NamadaChain { | ||
| fn config(&self) -> &CosmosSdkConfig { |
There was a problem hiding this comment.
Is this required since there is already the fn config() implementation from the ChainEndpoint https://github.com/informalsystems/hermes/pull/3705/files#diff-c8209ac0ce0499033b7cfc2981c4284a1ec525a3e6848bbf0a11856a011c9c2bR188?
crates/relayer/src/chain/namada.rs
Outdated
|
|
||
| let mut rpc_client = HttpClient::new(config.rpc_addr.clone()) | ||
| .map_err(|e| Error::rpc(config.rpc_addr.clone(), e))?; | ||
| rpc_client.set_compat_mode(CompatMode::V0_37); |
There was a problem hiding this comment.
Shouldn't the compat mode be retrieved from the configuration https://github.com/informalsystems/hermes/blob/master/config.toml#L439? It could default to V0_37 with a warning
| } | ||
|
|
||
| fn shutdown(self) -> Result<(), Error> { | ||
| Ok(()) |
There was a problem hiding this comment.
Is there a reason this method doesn't send the Shutdown to the Event Source?
crates/relayer/src/chain/namada.rs
Outdated
| } | ||
|
|
||
| fn version_specs(&self) -> Result<Specs, Error> { | ||
| unimplemented!() |
There was a problem hiding this comment.
Will this eventually be implemented?
crates/relayer/src/chain/namada.rs
Outdated
| heights.push(height); | ||
| } | ||
| // the key is not for a consensus state | ||
| Err(_) => continue, |
There was a problem hiding this comment.
Is this expected to happen often?
If not, a debug! would be nice to have the error. If it happens often then using trace! would be preferred.
crates/relayer/src/chain/namada.rs
Outdated
| ); | ||
| crate::telemetry!(query, self.id(), "query_upgraded_client_state"); | ||
|
|
||
| unimplemented!() |
There was a problem hiding this comment.
Will this eventually be implemented?
crates/relayer/src/chain/namada.rs
Outdated
| ); | ||
| crate::telemetry!(query, self.id(), "query_upgraded_consensus_state"); | ||
|
|
||
| unimplemented!() |
There was a problem hiding this comment.
Will this eventually be implemented?
Closes: #XXX
Description
To transfer tokens between Namada and Cosmos-base chains.
ChainConfigCosmosSdkConfigfor generating Tendermint light clientsNamadaChainasChainEndpointimplementationcrates/relayer/src/chain/namada.rsand files undercrates/relayer/src/chain/namadaPR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.