Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for simple async ICQ #3711

Merged
merged 16 commits into from
Dec 5, 2023
Merged

Add test for simple async ICQ #3711

merged 16 commits into from
Dec 5, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Nov 28, 2023

Closes: #3455

Description

This PR adds a test for async ICQs using Provenance chain to trigger the query.

Provenance chain has a CLI tx oracle send-query which trigger an async ICQ and will broadcast an Event that can be used to assert if the ICQ was successful or not.

In addition this PR also:

  • Removes the following chains from the CI jobs:
    • Evmos not able to update the version on Cosmos Nix, it was still running on v9.1.0 while it's on v15.0.0
    • Ibc-go simapp v4 and v5 as they reached End of Life the 31st of October
    • Stride non consumer as this was v8 of Stride

Most CI jobs were merged in a single using a new field in the matrix features to determine which chain can run special feature tests


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 added the O: tests Objective: Test more aspect of the relayer label Nov 28, 2023
@ljoss17 ljoss17 requested a review from romac November 28, 2023 09:54
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ljoss17 ljoss17 added the CI: multi-chains CI: Run the `multi-chains` integration test job on this PR label Dec 4, 2023
@ljoss17 ljoss17 merged commit 8096278 into master Dec 5, 2023
43 checks passed
@ljoss17 ljoss17 deleted the luca_joss/async-icq-tests branch December 5, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: multi-chains CI: Run the `multi-chains` integration test job on this PR O: tests Objective: Test more aspect of the relayer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Hermes' async CCQ functionality
2 participants