Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for number of events queried at once when clearing pending packets #3748

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jan 4, 2024

Closes: #3743

Description

  • Add query_packets_chunk_size config option
  • Add --query-packets-chunk-size flag to clear packets CLI

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from ljoss17 January 4, 2024 15:09
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!!
Only missing the changelog entry

@romac romac merged commit 94e23f0 into master Jan 5, 2024
35 checks passed
@romac romac deleted the romac/query_packets_chunk_size branch January 5, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config option for number of events queried at once when clearing pending packets
2 participants