Remove telemetry and rest-server feature flags
#3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
changed the title
telemetry feature flagtelemetry feature flag
Signed-off-by: Romain Ruetschi <romain@informal.systems>
romac
changed the title
telemetry feature flagtelemetry and rest-server feature flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
I don’t see the point anymore in feature-guarding the telemetry and REST servers, given that:
a) those can be enabled or disabled within the config file
b) I suspect the vast majority of users use Hermes via Docker, or a pre-built binary, or just build it with the default features.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.