ICS 031 event extraction perf improvement and refactor #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
force-pushed
the
ics31-event-extract
branch
from
7fba5e0
to
6ed048b
Compare
ljoss17
approved these changes
Apr 18, 2024
ljoss17
merged commit bdc05ca
into
luca_joss/fix-ics31-event-extraction
30 checks passed
ljoss17
added a commit
that referenced
this pull request
Apr 18, 2024
* Fix create_fork.sh used in misbehaviour test * Fix client upgrade test * Fix 'interchainquery' event extraction to extract all events instead of only the first one * Add changelog entry * Update .changelog/unreleased/bug-fixes/ibc-relayer/3954-interchainquery-missed-events.md Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> * ICS 031 event extraction perf improvement and refactor (#3956) * Small performance optimizations * Re-use existing `append_events` infrastructure * Cleanup * Add the flag '--reject-config-defaults' to the start command for Osmosis --------- Co-authored-by: Luca Joss <luca@informal.systems> Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> --------- Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> Co-authored-by: Romain Ruetschi <romain@informal.systems>
ljoss17
added a commit
that referenced
this pull request
Apr 18, 2024
* Use Gaia v15.2.0 in CI jobs * Update consumer chain bootstrap in test-framework * Fix ICQ test * Update dev-env script to work with Gaia v15 * Fix ICQ test by increasing time between ICQs * Fix Celestia CI job * Fix create_fork.sh used in misbehaviour test * Fix client upgrade test * Fix bug where only first CCQ event was extracted (#3955) * Fix create_fork.sh used in misbehaviour test * Fix client upgrade test * Fix 'interchainquery' event extraction to extract all events instead of only the first one * Add changelog entry * Update .changelog/unreleased/bug-fixes/ibc-relayer/3954-interchainquery-missed-events.md Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> * ICS 031 event extraction perf improvement and refactor (#3956) * Small performance optimizations * Re-use existing `append_events` infrastructure * Cleanup * Add the flag '--reject-config-defaults' to the start command for Osmosis --------- Co-authored-by: Luca Joss <luca@informal.systems> Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> --------- Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> Co-authored-by: Romain Ruetschi <romain@informal.systems> --------- Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if we can re-use the existing infrastructure we use for other events via
append_events.