Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement relaying of ConnOpenAck and ConnOpenConfirm #397

Merged
merged 17 commits into from
Nov 12, 2020

Conversation

ancazamfir
Copy link
Collaborator

@ancazamfir ancazamfir commented Nov 12, 2020

Closes: #359 and #360

Description

  • added the CLIs
  • make the necessary queries, validations
  • build and send the datagrams

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov-io
Copy link

Codecov Report

Merging #397 (673da07) into master (b1b37f5) will increase coverage by 21.1%.
The diff coverage is 64.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #397      +/-   ##
=========================================
+ Coverage    13.6%   34.8%   +21.1%     
=========================================
  Files          69     152      +83     
  Lines        3752    9830    +6078     
  Branches     1374    3575    +2201     
=========================================
+ Hits          513    3427    +2914     
- Misses       2618    6164    +3546     
+ Partials      621     239     -382     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/msgs.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 13.6% <0.0%> (-19.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/msgs/acknowledgement.rs 0.0% <0.0%> (ø)
modules/src/ics04_channel/msgs/recv_packet.rs 0.0% <0.0%> (ø)
modules/src/ics04_channel/msgs/timeout.rs 0.0% <0.0%> (ø)
modules/src/ics04_channel/packet.rs 0.0% <0.0%> (ø)
... and 283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abb563...673da07. Read the comment docs.

relayer-cli/src/commands/tx/connection.rs Show resolved Hide resolved
relayer-cli/src/commands/tx/connection.rs Show resolved Hide resolved
relayer/src/error.rs Outdated Show resolved Hide resolved
relayer/src/tx/connection.rs Show resolved Hide resolved
relayer/src/tx/connection.rs Outdated Show resolved Hide resolved
@ancazamfir ancazamfir merged commit 62d405a into master Nov 12, 2020
@ancazamfir ancazamfir deleted the anca/conn_open_rest_tx branch November 12, 2020 14:55
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relayer CLI for MsgConnectionOpenAck
3 participants