Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Tokio to version 0.3 #401

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Upgrade Tokio to version 0.3 #401

merged 3 commits into from
Nov 20, 2020

Conversation

romac
Copy link
Member

@romac romac commented Nov 16, 2020 •
edited
Loading

Closes: #402

Description

Upgrade Tokio to version 0.3.

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac marked this pull request as draft November 16, 2020 14:56
@romac romac mentioned this pull request Nov 16, 2020
Closed
5 tasks
@romac romac marked this pull request as ready for review November 16, 2020 15:41
@romac romac mentioned this pull request Nov 18, 2020
Merged
5 tasks
adizere
adizere approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Romain. LGTM!

@romac
Copy link
Member Author

romac commented Nov 18, 2020 •
edited
Loading

Should we wait until informalsystems/tendermint-rs#681 is merged so that we can point to tendermint-rs master directly?

@thanethomson @greg-szabo Do you think we could get it merged by Friday (ie. after the rc3 release)?

@thanethomson
Copy link
Contributor

Do you think we could get it merged by Friday (ie. after the rc3 release)?

I'm pretty sure we can merge it by Friday 👍

@informalsystems informalsystems deleted a comment from codecov-io Nov 20, 2020
@romac romac merged commit 000858a into master Nov 20, 2020
@informalsystems informalsystems deleted a comment from codecov-io Nov 20, 2020
@romac romac deleted the romac/upgrade-tokio branch December 15, 2020 13:14
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac
Upgrade Tokio to version 0.3 (informalsystems#401)
d846a6c 
* Upgrade Tokio to version 0.3

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Tokio to version 0.3.0
3 participants
@romac @thanethomson @adizere