Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Hermes v1.9.0 #4014

Merged
merged 11 commits into from
Jun 3, 2024
Merged

Release Hermes v1.9.0 #4014

merged 11 commits into from
Jun 3, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented May 31, 2024 •
edited
Loading

Closes: #4015

  • Bump all crate versions to the new version
  • Update Cargo.lock
  • Create a new release in the changelog, using unclog
    • If doing a release candidate (rc) version, then skip the unclog release step
  • Reassign unfinished issues of previous milestone to the next milestone
  • Notify the comms team about the pending new release by tagging @isa-belch as a reviewer here

@ljoss17 ljoss17 marked this pull request as ready for review May 31, 2024 09:22
@ljoss17 ljoss17 requested review from romac and isa-belch May 31, 2024 09:22
romac
romac reviewed Jun 3, 2024
View reviewed changes
CHANGELOG.md Outdated
Both servers can still be disabled in the configuration file, by setting `telemetry.enabled = false` and `rest.enabled = false`, respectively.
([\#3878](https://github.com/informalsystems/hermes/pull/3878))

### BUG FIXES
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this section after the features

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 37744d5

CHANGELOG.md Outdated Show resolved Hide resolved
romac
romac approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions remaining, looks good otherwise! Thanks!

ljoss17 and others added 3 commits June 3, 2024 13:14
@ljoss17 @romac
Update CHANGELOG.md
bbbcece 
Co-authored-by: Romain Ruetschi <romain@informal.systems>
Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
@ljoss17
Reordered changelog sections to be Breaking Changes, Features, Improv…
37744d5 
…ements and then Bug Fixes
@ljoss17
Merge branch 'master' into release/v1.9.0
71c2e16
@ljoss17 ljoss17 added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit a026d66 Jun 3, 2024
32 checks passed
@ljoss17 ljoss17 deleted the release/v1.9.0 branch June 3, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@isa-belch isa-belch Awaiting requested review from isa-belch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release Hermes v1.9.0
2 participants
@ljoss17 @romac