-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel open handshake message relaying/CLIs #403
Conversation
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
=========================================
+ Coverage 13.6% 33.4% +19.7%
=========================================
Files 69 154 +85
Lines 3752 10296 +6544
Branches 1374 3780 +2406
=========================================
+ Hits 513 3442 +2929
- Misses 2618 6245 +3627
+ Partials 621 609 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The present version seems to have compilation issues, following recent changes in tendermint-rs master (domaintype redefined to protobuf). So we should remember to revert cargo modifications, or adapt to these changes.
Otherwise looks good IMO!
* Add chan init and try CLIs * Add ack and confirm CLIs * Move to tendermint rc3 * Update changelog
Closes: #371 #372 #373 #374
Description
[will revert the Cargo.toml changes for tendermint dependencies after more testing]
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.