Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename proto-compiler cli arg #420

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

CharlyCst
Copy link
Contributor

Changed clone-sdk --path to clone-sdk --out to match readme.

Closes: #419

Description

Rename path to out in order to match Readme command examples.

The shortand is -o, so I assume that the intended argument was --out and not --path.


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

Changed `clone-sdk --path` to `clone-sdk --out` to match readme.
@codecov-io
Copy link

Codecov Report

Merging #420 (b39c5d9) into master (b1b37f5) will increase coverage by 22.8%.
The diff coverage is 67.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #420      +/-   ##
=========================================
+ Coverage    13.6%   36.5%   +22.8%     
=========================================
  Files          69     154      +85     
  Lines        3752   11092    +7340     
  Branches     1374    4129    +2755     
=========================================
+ Hits          513    4051    +3538     
- Misses       2618    6394    +3776     
- Partials      621     647      +26     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/msgs.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 13.6% <0.0%> (-19.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/msgs/chan_open_try.rs 67.0% <ø> (ø)
modules/src/ics04_channel/msgs/recv_packet.rs 63.5% <ø> (ø)
modules/src/ics04_channel/msgs/timeout.rs 69.2% <ø> (ø)
modules/src/ics04_channel/packet.rs 70.4% <ø> (+70.4%) ⬆️
... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db04e24...b39c5d9. Read the comment docs.

@romac
Copy link
Member

romac commented Nov 25, 2020

Thanks @CharlyCst!

@romac romac merged commit d732aef into informalsystems:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proto-compiler clone-sdk command takes --path instead of --out
3 participants