Improve redundant packet logs #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
reviewed
Nov 18, 2024
| Code::Err(code) if response.log.contains("packet messages are redundant") => { | ||
| info!( | ||
| ?response, | ||
| diagnostic = ?sdk_error_from_tx_sync_error_code(code.into(), estimated_gas), |
There was a problem hiding this comment.
Won't this just return "unknown tx error" since this error 22 is not handled in sdk_error_from_tx_sync_error_code, and moreover it is not an SDK error but an ibc-go one?
We can maybe just remove the diagnostic flag, and change the message to "all packets in tx have been relayed already, no fees were consumed" or something similar
There was a problem hiding this comment.
You are right, sorry I missed that.
Fixed it here 28d857b
I kept the diagnostic flag, but set it to the response log and added a code field
There was a problem hiding this comment.
And added the additional information about the fees here c8f7bd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4252
Description
PR author checklist:
unclog.Added tests: integration (for Hermes) or unit/mock tests (for modules).Updated code comments and documentation (e.g.,docs/).If guide has been updated, tag GitHub usermircea-cReviewer checklist:
Files changedin the GitHub PR explorer.